Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agenda): handle multiple VC per lecture #419

Closed
wants to merge 3 commits into from

Conversation

ShahabFallah
Copy link
Collaborator

@ShahabFallah ShahabFallah commented Jan 2, 2024

Closes #391 - LectureScreen.tsx
add one new dependecy --> Swiper
because I could find any other same UI component representing same functionality in the code
https://www.npmjs.com/package/react-native-swiper?activeTab=versions
the developers are active and it works for both Android and IOS

other changes to be consider :
because we have couple of variable with name VirtualClassrooms and it was a little bit confusing , we have :

  • associatedVirtualClassrooms ---> it is the videos lectures of that specific LectureCard
  • virtualClassroomsQuery ---> like the exact name in CourseVirtualClassroomScreen that retrieve all of the video lectures of corresponding course
  • and the final one virtualClassroomRet : which is the video retrieved from the Query

before the names were a little bit confusing to work on.

@ShahabFallah ShahabFallah requested a review from a team as a code owner January 2, 2024 10:58
@lpezzolla lpezzolla changed the title Feature/multiple vc feat(agenda): handle multiple VC per lecture Jan 2, 2024
@lpezzolla lpezzolla added the pr-hold Don't merge while this label is present label Feb 27, 2024
@github-actions github-actions bot added the cc-feat PR includes feature commit label Feb 27, 2024
@Bri74 Bri74 closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cc-feat PR includes feature commit pr-hold Don't merge while this label is present
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle multiple VCs associated to a single Lecture in agenda
3 participants