Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.0.5 #87

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

0.0.5 #87

wants to merge 13 commits into from

Conversation

politeauthority
Copy link
Owner

Major focus on documentation and unit testing.

Not yet ready for merge.

* Brining back base init

* WIP

* make_request unit test back add

* version update

* Adding handle_sleep

* Removing handle_sleep for more work

* Updating test uri

* Feature/more unit handle sleep (#75)

* Adding back handle sleep

* Fixing unit tests
* Brining back base init

* WIP

* make_request unit test back add

* version update

* Adding handle_sleep

* Removing handle_sleep for more work

* Updating test uri

* Feature/more unit handle sleep (#75)

* Adding back handle sleep

* Fixing unit tests

* Adding back test__get_headers

* Bringing back test__validate_conitentents

* Bringing back test__set_user_agent

* moar docs
* Brining back base init

* WIP

* make_request unit test back add

* version update

* Adding handle_sleep

* Removing handle_sleep for more work

* Updating test uri

* Feature/more unit handle sleep (#75)

* Adding back handle sleep

* Fixing unit tests

* Adding back test__get_headers

* Bringing back test__validate_conitentents
* Brining back base init

* WIP

* make_request unit test back add

* version update

* Adding handle_sleep

* Removing handle_sleep for more work

* Updating test uri

* Feature/more unit handle sleep (#75)

* Adding back handle sleep

* Fixing unit tests

* Adding back test__get_headers

* Bringing back test__validate_conitentents

* adding fmt_request_args

* moar tests

* WIP

* Adding internal proxies param test

* Adding Parse tests

* updates
* Adding some public method info

* more readme

* Better format

* wip

* Updating Read me
@pep8speaks
Copy link

pep8speaks commented Jun 7, 2019

Hello @politeauthority! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 235:80: E501 line too long (109 > 79 characters)

Line 461:80: E501 line too long (86 > 79 characters)
Line 719:80: E501 line too long (97 > 79 characters)
Line 720:80: E501 line too long (114 > 79 characters)

Line 46:80: E501 line too long (96 > 79 characters)

Line 46:80: E501 line too long (120 > 79 characters)
Line 47:80: E501 line too long (105 > 79 characters)
Line 57:80: E501 line too long (103 > 79 characters)
Line 61:80: E501 line too long (102 > 79 characters)
Line 65:80: E501 line too long (104 > 79 characters)
Line 69:80: E501 line too long (105 > 79 characters)
Line 255:80: E501 line too long (83 > 79 characters)
Line 257:80: E501 line too long (81 > 79 characters)
Line 263:80: E501 line too long (87 > 79 characters)
Line 271:80: E501 line too long (84 > 79 characters)
Line 360:80: E501 line too long (116 > 79 characters)

Comment last updated at 2019-07-05 01:09:24 UTC

* first add of public init

* Adding more to public init unit test

* pep8 fix

* wip

* Finishing public init

* wip

* Upping version

* Adding back save test

* tweaking filename

* upping version

* wip

* bring back unit test on set_header_once

* maybe pep8 fix?

* Adding __init__ tests

* Fix for default user agent name test

* Actually changing

* Adding better logging for failure to connect to BAS server

* Changing base val to match test and public

* code style bs

* Getting tests on the same page

* Feature/more unit public request (#88)

* Adding test for public requests method

* merging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants