Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust, python): Support reading UInt8, UInt16, Int8 and Int16 in newline delimited JSON #16105

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

krishanjmistry
Copy link

@krishanjmistry krishanjmistry commented May 7, 2024

Implements #16167

Currently, attempting to use the read_ndjson function with a schema that specifies these types triggers the panic:

_ => panic!("unexpected dtype when deserializing ndjson"),

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (acb601d) to head (df4776e).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16105      +/-   ##
==========================================
+ Coverage   80.97%   81.03%   +0.05%     
==========================================
  Files        1386     1387       +1     
  Lines      178479   178834     +355     
  Branches     2877     2882       +5     
==========================================
+ Hits       144530   144924     +394     
+ Misses      33458    33419      -39     
  Partials      491      491              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant