Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): Improves documentation for GCP and adds setters to ScanArgsParquet #15759

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andyquinterom
Copy link

This is a very small PR that makes some small quality of life improvements.

I added some setters for ScanArgsParquet to make it easier to built these options.

I added some documentation for CloudOptions with_gcp to make it more clear on how to use.

Copy link

codspeed-hq bot commented Apr 19, 2024

CodSpeed Performance Report

Merging #15759 will not alter performance

Comparing andyquinterom:improve-cloud-dx (a41552b) with main (d11da5e)

Summary

✅ 21 untouched benchmarks

@andyquinterom andyquinterom force-pushed the improve-cloud-dx branch 2 times, most recently from ea28d9d to ef04687 Compare April 19, 2024 17:59
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 81.35%. Comparing base (96e1f01) to head (a41552b).
Report is 35 commits behind head on main.

Files Patch % Lines
crates/polars-lazy/src/scan/parquet.rs 0.00% 36 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #15759    +/-   ##
========================================
  Coverage   81.35%   81.35%            
========================================
  Files        1379     1379            
  Lines      176603   176879   +276     
  Branches     2544     2543     -1     
========================================
+ Hits       143677   143904   +227     
- Misses      32443    32493    +50     
+ Partials      483      482     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego changed the title Improves documentation for GCP and adds setters to ScanArgsParquet feat(rust): Improves documentation for GCP and adds setters to ScanArgsParquet Apr 23, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature rust Related to Rust Polars labels Apr 23, 2024
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see the point of setter methods on a struct with public attributes?

@andyquinterom
Copy link
Author

I don't really see the point of setter methods on a struct with public attributes?

Hey! Thanks for taking the time to review this PR. I would say the main reason is ergonomics. For nested functions it's easier than declaring a new mutable variable and modifying it or using the ..Default::default() syntax.

I see other important structs like the CsvReader have setters which confused me for a while thinking that ScanArgsParquet would also.

Perhaps it's worth thinking of a unified setter/getter language for the different crates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants