Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure number of names passed to struct.rename_fields is valid #15624

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edavisau
Copy link
Contributor

Fixes #9052

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 13, 2024
Copy link

codspeed-hq bot commented Apr 13, 2024

CodSpeed Performance Report

Merging #15624 will not alter performance

Comparing edavisau:struct-rename-check (15259f9) with main (92902e6)

Summary

✅ 21 untouched benchmarks

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (92902e6) to head (15259f9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15624   +/-   ##
=======================================
  Coverage   81.25%   81.26%           
=======================================
  Files        1371     1371           
  Lines      175772   175774    +2     
  Branches     2531     2531           
=======================================
+ Hits       142831   142842   +11     
+ Misses      32464    32457    -7     
+ Partials      477      475    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing too few names to .struct.rename_fields removes remaining fields.
1 participant