Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix art credits #548

Draft
wants to merge 2 commits into
base: production
Choose a base branch
from
Draft

Fix art credits #548

wants to merge 2 commits into from

Conversation

WitherredAway
Copy link
Collaborator

@WitherredAway WitherredAway commented Sep 22, 2023 •
edited

  • Fixed art credits for 550289905079812106 (Lights Pyukumuku) and 745825974880436294 (Choco Milcery, Lights Pachirisu, Egg Basket Buneary)
  • Multi art credits now go more into detail about the role of the users

@WitherredAway
Art credit fixes
c8fe8f4 
- Add 'Idea by' to art credits
- Update artist names
- Fix 745825974880436294's credits
@WitherredAway
Fix art credits
bfb917e
oliver-ni
oliver-ni requested changes Sep 23, 2023
View reviewed changes
Copy link
Member

@oliver-ni oliver-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can we not use | in the art credits? And maybe change the word "idea" to "concept"

Like "Artwork by ID • Concept by ID"

@WitherredAway WitherredAway marked this pull request as draft October 8, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-ni oliver-ni oliver-ni requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WitherredAway @oliver-ni