New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARC support and fix all warnings and errors for Xcode 9.1 and iOS 11.1 #412
base: master
Are you sure you want to change the base?
Conversation
…nsigned long long)progress ofTotal:(unsigned long long)total;to + (void)updateProgressIndicator:(id)indicator withProgress:(unsigned long long)progress ofTotal:(unsigned long long)total;
…thObject:(id)object amount:(void *)amount callerToRetain:(id)caller; to + (void)performSelector:(SEL)selector onTarget:(id)target withObject:(id)object amount:(void *)amount callerToRetain:(id)caller;
…ug,fixed SSL issue
There’s a definite chance of this getting merged if several people comment to say that it works for them in their project & that they have also reviewed the code and found no issues. We’ll definitely not merge a pod spec unless it is very clearly marked as saying the asihttprequest is obsolete and should almost never be used. We don’t want anyone to accidentally incorporate asi into their projects. (I’d be interested to know why people are still using ASI too...!) |
In my case I am just maintaining an old project that uses the library. If it ain't broken... And you're right. I'll add the discontinued disclaimer. |
This reverts commit b391060. # Conflicts: # Classes/ASIHTTPRequest.m
…nto whlsxl-master # Conflicts: # Classes/ASIAuthenticationDialog.m # Classes/ASIDataCompressor.m # Classes/ASIDataDecompressor.m # Classes/ASIFormDataRequest.h # Classes/ASIFormDataRequest.m # Classes/ASIHTTPRequest.h # Classes/ASIHTTPRequest.m # Classes/ASIInputStream.h # Classes/ASIInputStream.m # Classes/ASINetworkQueue.h # Classes/ASINetworkQueue.m # External/Reachability/Reachability.h # External/Reachability/Reachability.m # iPhone.xcodeproj/project.pbxproj
Nice work . man! |
PR includes:
• Fixes from forks by @OpenFibers (#356), @John1261, @gbanfalvikl and @whlsxl (#377).
• Fixes for all build warnings in Xcode 9.2.
• Fixes for all Analyzer warnings in Xcode 9.2.
• Tested to be working on iOS 9.0~11.1.
• Not yet working on macOS.
While this PR will more likely never be merged, anyone can use it by adding
pod 'ASIHTTPRequest', :git => 'https://github.com/codelathe/asi-http-request.git'
to their Podfile.