Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XCTExpectFailure #75

Merged
merged 12 commits into from
Jan 23, 2024
Merged

Add XCTExpectFailure #75

merged 12 commits into from
Jan 23, 2024

Conversation

stephencelis
Copy link
Member

This PR takes the work @ZevEisenberg started with #59 and attempts to take it to the finish line. The changes I've made:

  1. Limited XCTExpectFailure to Objective-C platforms (it's still unavailable elsewhere).
  2. Finished implementing the official XCTExpectFailure signature, including enabled, issueMatcher and the continuation's return value.
  3. Added the version that does not take a failing block.

@stephencelis stephencelis mentioned this pull request Jan 23, 2024
Closed
@stephencelis stephencelis merged commit 197f47f into main Jan 23, 2024
5 checks passed
@stephencelis stephencelis deleted the xct-expect-failure branch January 23, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrandonw mbrandonw mbrandonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephencelis @mbrandonw @ZevEisenberg