Normalize image color spaces before comparison #665
+41
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the sRGB converted snapshot when doing the perceptual comparison This reduces the chances of failures when comparing snapshots in different color spaces
This was referenced Oct 22, 2022
Kaspik
approved these changes
Nov 8, 2022
jlcvp
approved these changes
Dec 1, 2022
icanswiftabit
approved these changes
Mar 2, 2023
|
Hey. Should we merge this PR after the rebase? Looks like it was approved, but never merged |
|
@stephencelis Please, is there a plan to merge this? |
# Conflicts: # Sources/SnapshotTesting/Snapshotting/NSImage.swift # Sources/SnapshotTesting/Snapshotting/UIImage.swift # Tests/SnapshotTestingTests/SnapshotTestingTests.swift
|
@stephencelis I will bump this topic cause there was no answer from few months Could you provide information what is blocking you from merging it into the main branch? It will be nice feature/fix that could reduce lots of issues. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use the sRGB converted snapshot when doing the perceptual comparison. This reduces the chances of failures when comparing snapshots using different color spaces.
This colorspace normalization technique was originally introduced in #446 and this PR extends it to both the reference and new images when performing perceptual image comparison.
Unit tests were added to verify that images in the P3 and sRGB colors spaces match after colorspace normalization.
Related Issues