Fix perception check in iOS 15. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimRoepcke
reviewed
Feb 21, 2024
Comment on lines
+44
to
+59
| if #available(iOS 16.0, *) { | ||
| WithPerceptionTracking { | ||
| Form { | ||
| Text(model.count.description) | ||
| Button("Decrement") { model.decrementButtonTapped() } | ||
| Button("Increment") { model.incrementButtonTapped() } | ||
| } | ||
| .presentationDetents([.medium]) | ||
| } | ||
| } else { | ||
| WithPerceptionTracking { | ||
| Form { | ||
| Text(model.count.description) | ||
| Button("Decrement") { model.decrementButtonTapped() } | ||
| Button("Increment") { model.incrementButtonTapped() } | ||
| } |
There was a problem hiding this comment.
Is this something we'd have to do in our code to if we're supporting iOS 15?
There was a problem hiding this comment.
@JimRoepcke No, this if #available check is only for .presentationDetents([.medium]), which is iOS 16+.
There was a problem hiding this comment.
Derp. (despite WithPerceptionTracking, my 👀 did not perceive or track that .presentationDetents line)
stephencelis
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like demangled action closures have a slightly different format in iOS 15 than 16/17, so I generalized the
isActionClosurehelper a bit.