Persist playback rate

[mr-fixit]

see Slack thread

to test

view an episode, change video playback rate. (gear icon)
quit safari, relaunch, view a different episode, check its rate

expect: its playback rate will be what you last used

[Matejkob]

I absolutely love this feature! It’s going to be such a relief not having to manually adjust the playback rate to 2.0 for each episode—thank you for adding this!

I've left one comment inline regarding a minor enhancement, but overall, the code looks good to me (but I'm not a JS expert).

I'm really excited to see this merged as soon as possible, @mbrandonw @stephencelis what do u think? 😇

[Matejkob]

I'm not an expert on JS, but this code looks solid to me. To make it even more bulletproof, we could ensure type safety by converting the value from localStorage to a number. Also, adding error handling when saving data to localStorage could be good, for example to handle a case when a user has disabled it.

Suggested change

	player.setPlaybackRate( localStorage.getItem('pf_playbackrate') || 1.0
	);
	player.on('playbackratechange', function(data) {
	localStorage.setItem('pf_playbackrate', data.playbackRate);
	});
	const defaultPlaybackRate = 1.0;
	const playbackRate = parseFloat(localStorage.getItem('pf_playbackrate')) || defaultPlaybackRate;
	player.setPlaybackRate(playbackRate);
	player.on('playbackratechange', function(data) {
	try {
	localStorage.setItem('pf_playbackrate', String(data.playbackRate));
	} catch (e) {
	console.error('Failed to save playback rate:', e);
	}
	});

[Matejkob]

I belive the same change can be done here:

Suggested change

	player.setPlaybackRate( localStorage.getItem('pf_playbackrate') || 1.0);
	player.on('playbackratechange', function(data) {
	localStorage.setItem('pf_playbackrate', data.playbackRate);
	});
	const defaultPlaybackRate = 1.0;
	const playbackRate = parseFloat(localStorage.getItem('pf_playbackrate')) || defaultPlaybackRate;
	player.setPlaybackRate(playbackRate);
	player.on('playbackratechange', function(data) {
	try {
	localStorage.setItem('pf_playbackrate', String(data.playbackRate));
	} catch (e) {
	console.error('Failed to save playback rate:', e);
	}
	});