User notification client fixes (#174)

* fixed delegate deallocating * assign UNUserNotificationCenter delegate before app finishes launching. --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com>
pointfreeco · Aug 23, 2023 · ed59ba8 · ed59ba8
1 parent f92cbd7
commit ed59ba8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Sources/AppFeature/AppDelegate.swift b/Sources/AppFeature/AppDelegate.swift
@@ -30,10 +30,11 @@ public struct AppDelegateReducer: Reducer {
     Reduce { state, action in
       switch action {
       case .didFinishLaunching:
+        let userNotificationsEventStream = self.userNotifications.delegate()
         return .run { send in
           await withThrowingTaskGroup(of: Void.self) { group in
             group.addTask {
-              for await event in self.userNotifications.delegate() {
+              for await event in userNotificationsEventStream {
                 await send(.userNotifications(event))
               }
             }

diff --git a/Sources/ComposableUserNotifications/LiveKey.swift b/Sources/ComposableUserNotifications/LiveKey.swift
@@ -9,7 +9,9 @@ extension UserNotificationClient: DependencyKey {
       AsyncStream { continuation in
         let delegate = Delegate(continuation: continuation)
         UNUserNotificationCenter.current().delegate = delegate
-        continuation.onTermination = { [delegate] _ in }
+        continuation.onTermination = { _ in
+          _ = delegate
+        }
       }
     },
     getNotificationSettings: {