-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing addrspace_operators.ll to kernel #1289
base: main
Are you sure you want to change the base?
Conversation
@@ -27,6 +27,7 @@ | |||
set(SOURCES_WITH_SLEEF abs.cl | |||
abs_diff.cl | |||
add_sat.cl | |||
addrspace_operators.ll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only tested the non-SLEEF version. I also wasn't sure how / where to add this exactly.
This might also have to be part of the generate.rb script. I'd appreciate if someone else could do the SLEEF changes if more changes are necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note that 4500774 explicitly removed more specialized variants of these functions from the "host" backend (but the new solution doesn't appear to work for me / new code isn't running (?): #1288 (comment)).
@@ -29,6 +29,7 @@ acos.cl | |||
acosh.cl | |||
acospi.cl | |||
add_sat.cl | |||
addrspace_operators.ll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note the new strategy in 4500774 for SLEEF which may or may not be broken.
I'm also not sure if this file is used in non-"host" backends where it might cause issues now.
Thanks for the effort, however this won't work as it is. Let me try to explain. As you have noticed, commit 4500774 removed these from There are multiple solutions (changing SPIRV-translator to output target AS numbers, or having the operators in separate files and linking it separately). But the simplest solution right now, could be to add the triple-underscore names to the |
Actually after re-reading the bugreport, ignore my suggestion about triple-underscore names, they only appear in the .so object files, and with the CPU driver this should never happen. Seems like there's some bug in the code from commit 4500774 and it misses the calls (possibly the remove-inside-loop ?). |
Closes #1288
Not sure how this ever worked. The functions that implement this were simply missing. The file was unused.
From what I can tell, this should have affected all platforms?! Is nobody using the CPU devices?