Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types.go #4566

Closed
wants to merge 1 commit into from
Closed

Conversation

VictorioBerra
Copy link

JSVM docs show uppercase c.Path() for middleware. The docs should use lowercase .path().

JSVM docs show uppercase `c.Path()` for middleware. The docs should use lowercase `.path()`.
@ganigeorgiev
Copy link
Member

ganigeorgiev commented Mar 15, 2024

Thank you. I'll apply the fix locally sometime later today as the generated types will also have to be updated.

This is not the case here as this is a manual comment, but note that the majority of the JSVM documentation is autogenerated from the Go code (using tygoja) and you may find other similar inconsistencies because we currently copy the original godoc block comments intact (with the exception that code blocks are wrapped in 3 ``` backticks since godoc doesn't support MD and supports only indentation).

ganigeorgiev added a commit that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants