Update ci #296
Open
Update ci #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanEricNitschke
force-pushed
the
update-ci
branch
from
3cdc473
to
352ad72
Compare
|
3.12 seems to crash because of the removal of distutils. |
|
Seem to be due to numpy not supporting 3.12 until 1.26.0 which is currently excluded from our requirements. |
|
I have updated the numpy dependency, maybe that now makes it work with 3.12. I also added pymend to the pre-commit configuration. Left me know what you think. |
|
Also i feel that our current setup with the installation is a bit messy. We have the requirements.txt, setup.py and pyproject.toml and all of them specify the dependencies. |
|
Updated all dependencies to the newest versions on pypi. Lets see if this builds and if all tests still pass. |
|
3.12 issue seem to now be shapely which does not have a wheel for 3.12 yet on pypi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating linters and adding python 3.12 to workflow to see if everything works.