demoinfocs v4 for CS2 support

[pnxenopoulos]

No description provided.

[JanEricNitschke]

Do we require a higher golang version with this or does 1.18 still work?

[pnxenopoulos]

Do we require a higher golang version with this or does 1.18 still work?

You're right. Demoinfocs docs say This library requires at least go 1.21 to run

[hojlund123]

github.com/markus-wa/demoinfocs-golang/v4 v4.0.0-beta.2

[hojlund123]

github.com/markus-wa/demoinfocs-golang/v4 v4.0.0-beta.2

[bk1n]

Hi guys, I'm new and a bit of a noob, especially with go, but want to help where I can as I use awpy a lot. Please tell me if I'm contributing incorrectly or saying something stupid - I don't mind and am here to learn!

First thing I've come across:

panic: invalid File-Type; expecting HL2DEMO in the first 8 bytes (ErrInvalidFileType)

goroutine 1 [running]:
main.checkError(...)
        D:/<user>/Documents/GitProjects/awpy/awpy/parser/parse_demo.go:2788
main.main()
        D:/<user>/Documents/GitProjects/awpy/awpy/parser/parse_demo.go:2636 +0x1d67
exit status 2
No file produced, error in calling Golang
[]
JSON path does not exist!

Solution - need to update parse_demo.go imports to latest demoinfocs-golang version:

import (
	"encoding/json"
	"errors"
	"flag"
	"fmt"
	"log"
	"math"
	"os"
	"strconv"
	"strings"

	dem "github.com/markus-wa/demoinfocs-golang/v4/pkg/demoinfocs"
	common "github.com/markus-wa/demoinfocs-golang/v4/pkg/demoinfocs/common"
	events "github.com/markus-wa/demoinfocs-golang/v4/pkg/demoinfocs/events"
)

Should I just stick this in a commit and push directly to branch?

[JanEricNitschke]

Hi @bk1n ,

thanks for your help. As you are not a maintainer i do not think that you can push to this branch here. This is something that @pnxenopoulos has to do.

Cheers
Jan-Eric

[JanEricNitschke]

It seems that the actual update to the v4/cs2 parser has broken exactly one test. Specifically a pretty recently introduced one for a pov demo. And it does not seem to be a cleaning test as the number of rounds uncleaned is just 2.

[JanEricNitschke]

The other POV demo tests also seems to have failed. Which is interesting because it didnt do that locally for me.

Maybe we can now add a CS2 demo to the tests and try to figure out what is going wrong with the POV demos.