This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Fix: #2786 - Pass cookiecontainer to HttpClientHandler to support provisioning client side pages on tenant with Federated authentication login #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oppie85
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
In the ClientSidePage code, serveral non-CSOM API's are called (example: GetClientSideWebPartsAsync). These are authenticated using either the explicit credentials or Authorization header. However, when dealing with a tenant that uses Federation, these calls will throw an error unless the Federation cookies are also passed to the HttpClientHandler. This fix reads the cookies in InitializeSecurityAsync and passes them to all the relevant API's in the same manner that the accessToken is.