Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Update ObjectFiles.cs #2696

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update ObjectFiles.cs #2696

wants to merge 1 commit into from

Conversation

bricenocar
Copy link

Setting properties before checking in causes an error. ref issue: #1831

Q A
Bug fix? yes
New feature? no
New sample? no
Related issues? fixes #1831, mentioned in #2335

What's in this Pull Request?

Setting properties before checking in causes an error "The file is not checked out" when trying to set the webparts in a file while provisioning a pnp template. The fix was to move the update properties logic before the check in happens.

Setting properties before checkin causes an error "The file is not checked out" when trying to set the webparts. ref issue: pnp#1831
@jansenbe
Copy link
Contributor

jansenbe commented Sep 3, 2020

Hi @bricenocar , this change conflicts with the change done a while ago by @czullu (#2610). Can you cross check this PR with him and if needed update. @czullu's case seems to handle "Libraries with ForceCheckout", so that might be the difference. If so that must then be taken in account into this PR.

@jansenbe jansenbe self-assigned this Sep 3, 2020
@jansenbe jansenbe added Needs: Discussion 🙋 status:tracked Triaged and are being investigated further labels Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs: Discussion 🙋 status:tracked Triaged and are being investigated further
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants