Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Added GetPnPSiteHistoricalVersionsStatus #2832

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Added GetPnPSiteHistoricalVersionsStatus #2832

wants to merge 4 commits into from

Conversation

ZhuoWeiLi
Copy link

Before creating a pull request, make sure that you have read the contribution file located at

https://github.com/pnp/PnP-PowerShell/blob/dev/CONTRIBUTING.md

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Fixes #X, partially fixes #Y, mentioned in #Z, etc.

What is in this Pull Request ?

Added a new command for getting the status of the upcoming Historical Versions feature for a site. This feature allows sites to make versions searchable for eDiscovery.

Guidance

This is a draft pull request to keep track of the feature since the CSOM API needed for this command hasn't been published yet. Will publish this pull request once the API is available.

@ZhuoWeiLi ZhuoWeiLi changed the title Site historical versions status Added GetPnPSiteHistoricalVersionsStatus Aug 5, 2020
@wobba wobba self-assigned this Aug 7, 2020
Remarks = "Returns the status of the feature as well as the number of documents processed for the site if the feature is enabled.",
SortOrder = 1)]
public class GetSiteHistoricalVersionsStatus : PnPWebCmdlet
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erwinvanhunen would it make sense to inherit from PnPAdminCmdlet instead, and maybe move the cmdlet to the Admin folder instead of search?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably would make more sense indeed. What's the current status of the availability of this API? Does anyone know? Still doesn't seem to compile here against the latest CSOM version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no wait until the CSOM change is pushed. Don't have an ETA, but maybe @VesaJuvonen has track of this?

@wobba wobba marked this pull request as ready for review August 10, 2020 08:29
@wobba wobba marked this pull request as draft August 10, 2020 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants