Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2173): add explicit dep for @react-spring/rafz for yarn and pnpm #2270

Closed
wants to merge 2 commits into from

Conversation

wegry
Copy link

@wegry wegry commented Apr 8, 2024

Why

#2173 points out that TypeScript types for @react-spring/web depend on @react-spring/rafz. In Yarn 4 with PnP enabled (and maybe pnpm with no-hoist enabled), this requires the user to explicitly import or override dependencies for @react-spring/web.

What

This PR adds the TypeScript dependency explicitly.

Checklist

  • Ready to be merged

Closes #2173

Copy link

changeset-bot bot commented Apr 8, 2024

⚠️ No Changeset found

Latest commit: 3f557f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-spring ❌ Failed (Inspect) Apr 10, 2024 5:18pm

@wegry wegry marked this pull request as ready for review April 8, 2024 12:22
@joshuaellis
Copy link
Member

Thanks for the contribution! You need to run yarn to update the lockfile :)

@wegry
Copy link
Author

wegry commented Apr 9, 2024

You need to run yarn to update the lockfile :)

@joshuaellis done.

@joshuaellis
Copy link
Member

⚠️ No Changeset found

Latest commit: 3f557f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

did you see this message? :)

@wegry
Copy link
Author

wegry commented Apr 10, 2024

@joshuaellis I had not. See 3e3dbac. Not sure why style checks are failing now for files I didn't change though.

@wegry wegry closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Cannot find module '@react-spring/rafz'
2 participants