Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ESM / CJS bundlers etc. #2144

Merged
merged 1 commit into from
Jun 25, 2023
Merged

fix: ESM / CJS bundlers etc. #2144

merged 1 commit into from
Jun 25, 2023

Conversation

joshuaellis
Copy link
Member

@joshuaellis joshuaellis commented Apr 10, 2023

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2023

🦋 Changeset detected

Latest commit: 65fc02c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
react-spring Patch
@react-spring/animated Patch
@react-spring/parallax Patch
@react-spring/shared Patch
@react-spring/types Patch
@react-spring/native Patch
@react-spring/core Patch
@react-spring/rafz Patch
@react-spring/konva Patch
@react-spring/three Patch
@react-spring/zdog Patch
@react-spring/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-spring ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 5:03pm

@github-actions
Copy link

github-actions bot commented Apr 10, 2023

Size Change: +93.5 kB (+165%) 🆘

Total Size: 150 kB

Filename Size Change
packages/animated/dist/esm/index.js 0 B -1.77 kB (removed) 🏆
packages/animated/dist/index.js 0 B -2.08 kB (removed) 🏆
packages/core/dist/esm/index.js 0 B -11.4 kB (removed) 🏆
packages/core/dist/index.js 0 B -11.6 kB (removed) 🏆
packages/parallax/dist/esm/index.js 0 B -1.7 kB (removed) 🏆
packages/parallax/dist/index.js 0 B -2 kB (removed) 🏆
packages/rafz/dist/esm/index.js 0 B -906 B (removed) 🏆
packages/rafz/dist/index.js 0 B -1.14 kB (removed) 🏆
packages/react-spring/dist/esm/index.js 0 B -52 B (removed) 🏆
packages/react-spring/dist/index.js 0 B -335 B (removed) 🏆
packages/shared/dist/esm/index.js 0 B -6.95 kB (removed) 🏆
packages/shared/dist/index.js 0 B -7.25 kB (removed) 🏆
packages/types/dist/esm/index.js 0 B -53 B (removed) 🏆
packages/types/dist/index.js 0 B -323 B (removed) 🏆
targets/konva/dist/esm/index.js 0 B -336 B (removed) 🏆
targets/konva/dist/index.js 0 B -618 B (removed) 🏆
targets/native/dist/esm/index.js 0 B -752 B (removed) 🏆
targets/native/dist/index.js 0 B -870 B (removed) 🏆
targets/three/dist/esm/index.js 0 B -347 B (removed) 🏆
targets/three/dist/index.js 0 B -685 B (removed) 🏆
targets/web/dist/esm/index.js 0 B -2.2 kB (removed) 🏆
targets/web/dist/index.js 0 B -2.43 kB (removed) 🏆
targets/zdog/dist/esm/index.js 0 B -308 B (removed) 🏆
targets/zdog/dist/index.js 0 B -656 B (removed) 🏆
packages/animated/dist/cjs/index.js 150 B +150 B (new file) 🆕
packages/animated/dist/react-spring_animated.legacy-esm.js 2.62 kB +2.62 kB (new file) 🆕
packages/animated/dist/react-spring_animated.modern.development.mjs 2.63 kB +2.63 kB (new file) 🆕
packages/animated/dist/react-spring_animated.modern.mjs 2.62 kB +2.62 kB (new file) 🆕
packages/animated/dist/react-spring_animated.modern.production.min.mjs 1.78 kB +1.78 kB (new file) 🆕
packages/core/dist/cjs/index.js 147 B +147 B (new file) 🆕
packages/core/dist/react-spring_core.legacy-esm.js 17.8 kB +17.8 kB (new file) 🆕
packages/core/dist/react-spring_core.modern.development.mjs 17.8 kB +17.8 kB (new file) 🆕
packages/core/dist/react-spring_core.modern.mjs 17.8 kB +17.8 kB (new file) 🆕
packages/core/dist/react-spring_core.modern.production.min.mjs 11.3 kB +11.3 kB (new file) 🆕
packages/parallax/dist/cjs/index.js 151 B +151 B (new file) 🆕
packages/parallax/dist/react-spring_parallax.legacy-esm.js 2.4 kB +2.4 kB (new file) 🆕
packages/parallax/dist/react-spring_parallax.modern.development.mjs 2.41 kB +2.41 kB (new file) 🆕
packages/parallax/dist/react-spring_parallax.modern.mjs 2.4 kB +2.4 kB (new file) 🆕
packages/parallax/dist/react-spring_parallax.modern.production.min.mjs 1.74 kB +1.74 kB (new file) 🆕
packages/rafz/dist/cjs/index.js 148 B +148 B (new file) 🆕
packages/rafz/dist/react-spring_rafz.legacy-esm.js 1.46 kB +1.46 kB (new file) 🆕
packages/rafz/dist/react-spring_rafz.modern.development.mjs 1.46 kB +1.46 kB (new file) 🆕
packages/rafz/dist/react-spring_rafz.modern.mjs 1.45 kB +1.45 kB (new file) 🆕
packages/rafz/dist/react-spring_rafz.modern.production.min.mjs 953 B +953 B (new file) 🆕
packages/react-spring/dist/cjs/index.js 143 B +143 B (new file) 🆕
packages/react-spring/dist/react-spring.legacy-esm.js 110 B +110 B (new file) 🆕
packages/react-spring/dist/react-spring.modern.development.mjs 118 B +118 B (new file) 🆕
packages/react-spring/dist/react-spring.modern.mjs 108 B +108 B (new file) 🆕
packages/react-spring/dist/react-spring.modern.production.min.mjs 102 B +102 B (new file) 🆕
packages/shared/dist/cjs/index.js 150 B +150 B (new file) 🆕
packages/shared/dist/react-spring_shared.legacy-esm.js 10.5 kB +10.5 kB (new file) 🆕
packages/shared/dist/react-spring_shared.modern.development.mjs 10.5 kB +10.5 kB (new file) 🆕
packages/shared/dist/react-spring_shared.modern.mjs 10.5 kB +10.5 kB (new file) 🆕
packages/shared/dist/react-spring_shared.modern.production.min.mjs 7.64 kB +7.64 kB (new file) 🆕
packages/types/dist/cjs/index.js 148 B +148 B (new file) 🆕
packages/types/dist/react-spring_types.legacy-esm.js 120 B +120 B (new file) 🆕
packages/types/dist/react-spring_types.modern.development.mjs 125 B +125 B (new file) 🆕
packages/types/dist/react-spring_types.modern.mjs 117 B +117 B (new file) 🆕
packages/types/dist/react-spring_types.modern.production.min.mjs 114 B +114 B (new file) 🆕
targets/konva/dist/cjs/index.js 149 B +149 B (new file) 🆕
targets/konva/dist/react-spring_konva.legacy-esm.js 443 B +443 B (new file) 🆕
targets/konva/dist/react-spring_konva.modern.development.mjs 449 B +449 B (new file) 🆕
targets/konva/dist/react-spring_konva.modern.mjs 441 B +441 B (new file) 🆕
targets/konva/dist/react-spring_konva.modern.production.min.mjs 384 B +384 B (new file) 🆕
targets/native/dist/cjs/index.js 149 B +149 B (new file) 🆕
targets/native/dist/react-spring_native.legacy-esm.js 981 B +981 B (new file) 🆕
targets/native/dist/react-spring_native.modern.development.mjs 988 B +988 B (new file) 🆕
targets/native/dist/react-spring_native.modern.mjs 979 B +979 B (new file) 🆕
targets/native/dist/react-spring_native.modern.production.min.mjs 796 B +796 B (new file) 🆕
targets/three/dist/cjs/index.js 148 B +148 B (new file) 🆕
targets/three/dist/react-spring_three.legacy-esm.js 462 B +462 B (new file) 🆕
targets/three/dist/react-spring_three.modern.development.mjs 468 B +468 B (new file) 🆕
targets/three/dist/react-spring_three.modern.mjs 460 B +460 B (new file) 🆕
targets/three/dist/react-spring_three.modern.production.min.mjs 392 B +392 B (new file) 🆕
targets/web/dist/cjs/index.js 147 B +147 B (new file) 🆕
targets/web/dist/react-spring_web.legacy-esm.js 2.92 kB +2.92 kB (new file) 🆕
targets/web/dist/react-spring_web.modern.development.mjs 2.92 kB +2.92 kB (new file) 🆕
targets/web/dist/react-spring_web.modern.mjs 2.92 kB +2.92 kB (new file) 🆕
targets/web/dist/react-spring_web.modern.production.min.mjs 2.24 kB +2.24 kB (new file) 🆕
targets/zdog/dist/cjs/index.js 148 B +148 B (new file) 🆕
targets/zdog/dist/react-spring_zdog.legacy-esm.js 396 B +396 B (new file) 🆕
targets/zdog/dist/react-spring_zdog.modern.development.mjs 401 B +401 B (new file) 🆕
targets/zdog/dist/react-spring_zdog.modern.mjs 393 B +393 B (new file) 🆕
targets/zdog/dist/react-spring_zdog.modern.production.min.mjs 352 B +352 B (new file) 🆕

compressed-size-action

@Dixie-fmp
Copy link

Hi, we're hoping this will fix the issue we're seeing on Safari versions 14 and earlier. What's your time scale on getting this released? :)

Update tests.yml

chore: fix nextjs test

Create gorgeous-experts-double.md

chore: refactor

chore: update yarn.lock

Update tests.yml

Update tests.yml

Update tests.yml

Update tests.yml

Update tests.yml

chore: tweaks

chore: fix node test

fix: cjs test run

Update main.tsx

Update tests.yml

fix: unit tests

chore: prettify

chore: update github workflow

chore: update ci package for are-the-types-wrong

chore: add package.json to export map

fix: yarn pack not packing

chore: re-add pack

chore: rework build pipeline (again)

chore: remove node-esm test temporarily

chore: tweak build file positions

chore: pretty

fix: fixes

chore: update node-standard yarn.lock

chore: add node-esm test

fix: use more advanced bundling set up

based off immer

Update tsup.config.base.ts

fix: jest
@joshuaellis joshuaellis merged commit 52cc710 into main Jun 25, 2023
18 of 21 checks passed
@joshuaellis joshuaellis deleted the fix/build-for-mjs branch June 25, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants