toggle reverse on useTransitions #1896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1d6f848:
|
joshuaellis
requested changes
May 19, 2022
There was a problem hiding this comment.
It looks like you've gone for two approaches here, i'd prefer to go for the prop styled method as opposed to adding another argument to transition.
I think reverse would be better because this is in sync with the language we use in regards to loop.
We should also add some tests for this new feature.
misbahkhalilaz
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It is not currently possible to reverse the order of the useTransition animation.
What
I changed the render transition function to allow an optional reverse prop and added the optional toggleReverse prop in the hook to change the transition ordering after every render.
Checklist
This is an attempt to solve https://github.com/pmndrs/react-spring/issues/1794