fix: <Select/> when !multiple || !box
#1613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the props `multiple` and `box` are defined, `downed` is being set through eventListeners set on the window inside an effect. If they are not set, `downed` before this commit was never set, which caused `onChange` to never run. To solve this bug I add a condition `shouldDragSelect = multiple && box` a conditional event-listeners on `<group/>` in case `!shouldDragSelect` so that when `shouldDragSelect` `down` is being set through the event-listeners set inside the effect, and if `!shouldDragSelect` it is being set whenever one of Select's children is being clicked.
Before commit the effect relying on `shouldDragSelect` did not include it in its dependencies. Neither did the code before this branch, so I am unsure if this was a conscious act or not, but I believe it could cause a bug where one of the props is changed but event-listeners are not properly cleaned up. besides this I return `undefined` instead of `null` in case `shouldDragSelect` in `<group/>` event-listeners
bigmistqke
changed the title
<Select/> when !multiple || !box`<Select/> when !multiple || !box
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4839f66:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When the props
multipleandboxare defined,downedis being set through eventListeners set on the window inside an effect. If they are not set,downedwas initially never set, which causedonChangeto never run.An example of
Selectnot working is theWith <Select/>-story ofTransformControls.What
const shouldDragSelect = multiple && box<group/>in case!shouldDragSelectso thatshouldDragSelect === truedownedis being set through the event-listeners set inside the effectshouldDragSelect === falsedownedis being set whenever one ofSelect's children is being clicked.Besides that I also added
shouldDragSelectas a dependency of the effect, before this commit themultipleorboxprops weren't included, which could have caused bugs too.Checklist