Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix #4990 - Add attribute @PackageQualifier to ASTClassType #5005

Merged
merged 7 commits into from
May 23, 2024

Conversation

oowekyala
Copy link
Member

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added this to the 7.2.0 milestone May 11, 2024
@pmd-test
Copy link

pmd-test commented May 11, 2024

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we should add an explicit test to verify the use case, that this change is supposed to fix. You can use the code snippet from #4946 and verify that that PackageQualifier has the expected values (the package name). In most tests I've seen here, we expect "null"....

Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel merged commit bbec7fd into pmd:master May 23, 2024
3 checks passed
adangel added a commit that referenced this pull request May 23, 2024
adangel added a commit that referenced this pull request May 23, 2024
Merge pull request #5005 from oowekyala:issue4990-package-qualifier-attribute
@oowekyala oowekyala deleted the issue4990-package-qualifier-attribute branch May 23, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java] Add an attribute @PackageQualifier to ASTClassType
4 participants