Convert keyword list so it becomes rabbit_common compatible #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ono
requested changes
Dec 30, 2021
There was a problem hiding this comment.
I personally prefer to use the rabbitmq compatible format but I think that we should support Utils.to_type_tuple/1 to keep it consistent.
It looks good for Exchange. Can you remove headers function and use declare directly instead please? Then I will merge this PR and put the same conversion to elsewhere.
Thanks!
| @spec headers(Channel.t(), Basic.exchange(), keyword) :: :ok | Basic.error() | ||
| def headers(%Channel{} = channel, exchange, options \\ []) do | ||
| declare(channel, exchange, :headers, options) | ||
| end |
There was a problem hiding this comment.
This level of utility should belong to application level. Can you remove this function and simply use Exchange.declare/4 instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.