Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLint everything and add to CI #105

Merged
merged 8 commits into from Mar 18, 2024
Merged

HLint everything and add to CI #105

merged 8 commits into from Mar 18, 2024

Conversation

siddharth-krishna
Copy link
Collaborator

@siddharth-krishna siddharth-krishna commented Mar 18, 2024

Spring cleaning: thought I'd get rid of all the blue squiggles while there weren't many open PRs. :)

I ran:

cabal install apply-refact hlint
for f in `git ls-files | grep -e '.*\.hs'`; do echo linting $f; hlint --refactor --refactor-options="-i" $f; done

And manually checked that nothing semantically changed.

Also trying out a GitHub action that should generate lint suggestions in the PRs.
I thought the action would add PR suggestions in the web interface which could be applied with one click, but it didn't do that, and going through the CI logs feels a bit painful. This other action might do that, but it needs some security/token set up so I'll save it for another time:
https://github.com/haskell-actions/hlint-scan

For now, it just adds a hint to the PR diff view:
image

Copy link
Contributor

@albertov albertov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

@siddharth-krishna siddharth-krishna marked this pull request as ready for review March 18, 2024 14:27
@siddharth-krishna siddharth-krishna merged commit 2541d3e into main Mar 18, 2024
1 check passed
@siddharth-krishna siddharth-krishna deleted the sidk-hlint-all branch March 18, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants