allow disabling colorscale dropdown #832
Conversation
VeraZab
force-pushed
the
colorscalepicker-adj
branch
2 times, most recently
from
f01ec24
to
7a5c0c6
Compare
|
Colorscales are aligned We can not display the dropdown This is a little ugly the colorscale titles are a bit too close to the border, but hey, I was trying to make the colorscales all align, so it seems hard to have it both ways That's another view |
|
Oh wow, I didn't think it would be possible for the component to extend left under the label... nice! |
VeraZab
force-pushed
the
colorscalepicker-adj
branch
from
ed43204
to
567616d
Compare
|
I do see that the first colorscale pulls a bit to the left, not sure where that's from, but it looks like its really more visible in the percy screenshot than on my computer.. |
|
I'm not sure what's up with percy, this is pretty aligned |
|
@nicolaskruchten, I think this one's ready to merge. |
|
Note: when this release happens we will need a new Falcon release as well, which I'll help you do :) |
|
💃 |
|
oh yeah, nice CSS work here, I love the "no jumping"! Can we do a last check in FF and IE11 please as well? |
|
hmm, the widgets don't look good in IE.. fixing.. |
|
Looks like, I have to deal with non-webkit browsers scrollbars, they take up a lot of space and mess up the design of wider components
And yes this affects the datetimepicker too |
|
Implementing custom scrollbars cross browser everywhere, seems like a big change, I haven't found a css solution that could work cross browser, maybe we could look into using a react/js one, something like: https://grsmto.github.io/simplebar/ But that's for another time, I'm opening an issue: #835 |
|
This is ok for now I think |
part of : https://github.com/plotly/streambed/pull/12174 and https://github.com/plotly/streambed/pull/12116
Needed to add a sass stub for jest: jestjs/jest#3094 (comment)