Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

fix(editor): fix block actions menu button style #288

Merged
merged 1 commit into from Jul 8, 2022

Conversation

Darmody
Copy link
Contributor

@Darmody Darmody commented Jul 8, 2022

fix #107

@Darmody Darmody requested a review from toadfansboy as a code owner July 8, 2022 07:29
@Darmody Darmody temporarily deployed to pr_preview July 8, 2022 07:41 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

This pull request has been built and is available for preview at pr288.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@Darmody Darmody force-pushed the fix-block-actions-button-style branch from c4408d4 to d98476e Compare July 8, 2022 08:14
@Darmody Darmody requested a review from stackia as a code owner July 8, 2022 08:14
@Darmody Darmody temporarily deployed to pr_preview July 8, 2022 08:19 Inactive
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #288 (d98476e) into main (d640229) will increase coverage by 0.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   62.61%   63.12%   +0.50%     
==========================================
  Files         760      787      +27     
  Lines       13817    13934     +117     
  Branches     2689     2681       -8     
==========================================
+ Hits         8652     8796     +144     
+ Misses       4580     4557      -23     
+ Partials      585      581       -4     
Flag Coverage Δ
frontend-unit 63.12% <100.00%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ockActions/BlockActionButton/BlockActionButton.tsx 88.88% <100.00%> (+1.01%) ⬆️
...omponents/blockViews/BlockActions/BlockActions.tsx 85.71% <100.00%> (ø)
packages/editor/src/components/ui/Icon/Icon.tsx 97.36% <100.00%> (+0.07%) ⬆️
packages/formula/src/controls/button.ts 10.00% <0.00%> (-10.00%) ⬇️
packages/formula/src/controls/switch.ts 8.33% <0.00%> (-8.34%) ⬇️
...Views/EmbedView/embedViews/ImageView/ImageView.tsx 81.81% <0.00%> (-3.90%) ⬇️
packages/formula/src/controls/row.ts 73.33% <0.00%> (-2.23%) ⬇️
packages/formula/src/controls/block.ts 84.21% <0.00%> (-1.76%) ⬇️
packages/formula/src/controls/column.ts 91.37% <0.00%> (-1.73%) ⬇️
packages/formula/src/grammar/util.ts 76.51% <0.00%> (-1.35%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d640229...d98476e. Read the comment docs.

@Darmody Darmody merged commit dea4380 into main Jul 8, 2022
@Darmody Darmody deleted the fix-block-actions-button-style branch July 8, 2022 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Inconsistency: btn-icon
2 participants