Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

UI Inconsistency: btn-icon #107

Closed
zaotang opened this issue Jun 23, 2022 · 7 comments · Fixed by #288
Closed

UI Inconsistency: btn-icon #107

zaotang opened this issue Jun 23, 2022 · 7 comments · Fixed by #288
Assignees
Labels
bug Something isn't working ux This one is UX-related

Comments

@zaotang
Copy link

zaotang commented Jun 23, 2022

image

The hover status of this button should be:
image

https://www.figma.com/file/YcVOEbdec2oqyKrYFSkeYW/Components-Base?node-id=3673%3A11297

@z4cki
Copy link
Contributor

z4cki commented Jul 11, 2022

@Darmody the cursor style should be grabbing when drag and drop

@z4cki z4cki reopened this Jul 11, 2022
@Darmody
Copy link
Contributor

Darmody commented Jul 11, 2022

@Darmody the cursor style should be grabbing when drag and drop

@jizhekai This feature is not needed now. Confirmed by @zaotang

@Darmody Darmody closed this as completed Jul 11, 2022
@Darmody
Copy link
Contributor

Darmody commented Jul 11, 2022

Sorry, I misunderstood the problem. It should be a grabbing cursor when dragging.

@Darmody Darmody reopened this Jul 11, 2022
@Darmody
Copy link
Contributor

Darmody commented Jul 12, 2022

react-dnd/react-dnd#325 (comment)
https://bugs.chromium.org/p/chromium/issues/detail?id=1232555

According to the discussions above, Chrome doesn't support custom cursors while drag start.
If we want to do that, we might need to implement the drag feature in the mouse event way.
https://stackoverflow.com/questions/44447210/custom-cursor-with-drag-and-drop-an-html-element-without-libraries

@jizhekai @stackia

@Darmody
Copy link
Contributor

Darmody commented Jul 13, 2022

@stackia it involved a significant refactor for node-drag. Since the node-drag feature is also not perfect for now, how about we create a new issue for node-drag including this cursor issue?

@stackia
Copy link
Contributor

stackia commented Jul 13, 2022

@stackia it involved a significant refactor for node-drag. Since the node-drag feature is also not perfect for now, how about we create a new issue for node-drag including this cursor issue?

@Darmody Yes I'll create a new issue about dragging. We can close this one for now.

@stackia stackia closed this as completed Jul 13, 2022
@z4cki
Copy link
Contributor

z4cki commented Jul 18, 2022

@zaotang @BrickDoctor @ziyanchen327 LGTM, grabbing cursor is a known issue. will create a new issue about it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ux This one is UX-related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants