Removes Illegal reflective access of DelegatingClassLoader #8355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
under JDK 9+ DelegatingClassLoader raised an Illegal reflective access error. By changing ApplicationClassLoaderProvider to use an URLClassLoader the whole reflective access can be removed.
richdougherty
approved these changes
Apr 17, 2018
|
@Schmith Is there an issue raised on guice side already, or should I create one? |
|
There is: google/guice#1133 |
|
What version of Play Framework will be patched from this merge? |
|
@unistylist, aiming for 2.6.14 - see #8420. |
richdougherty
pushed a commit
that referenced
this pull request
May 21, 2018
ignasi35
added a commit
to ignasi35/playframework
that referenced
this pull request
Dec 11, 2019
ignasi35
added a commit
to ignasi35/playframework
that referenced
this pull request
Dec 19, 2019
gslowikowski
added a commit
to play2-maven-plugin/play2-maven-plugin
that referenced
this pull request
Jan 5, 2020
Align Maven implementation with original Playframework! code - change: playframework/playframework@e6ed774 playframework/playframework#8355 playframework/playframework#8350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful things
Fixes
Fixes #8350
Purpose
under JDK 9+ DelegatingClassLoader raised an Illegal reflective access
error.
By changing ApplicationClassLoaderProvider to use an URLClassLoader
the whole reflective access can be removed.
Background Context
Currently nobody uses
ApplicationClassLoaderProviderwith a differentClassLoaderthan anURLClassLoader. I even checked Lagom and they basically have the same classes than Play which also implement and URLClassLoader. Gradle does not use anything fromplay.runsupport.After that PR on sbt 1.1.2 and master Branch we would still see (and of course we still need to add jaxb):
But that can't be fixed on our side