New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 17 #10819
Java 17 #10819
Conversation
0659c26
to
89c1b7f
Compare
6019c6c
to
bc1d1c3
Compare
It seems like a big problem is the deeply transitive dependency on Adding VM arg The new guice release For this and other reasons I do think it is imperative that play framework migrates to guice 5. |
@mkurz that is great news! 🥇 |
59cf282
to
5837515
Compare
|
You can follow the 2.8.14 release here: playframework/play-meta#217 |
Thanks @mkurz . Build seems successfully completed. Today or tomorrow, I'm fine & thanks for your quick reply 🙏🏽 |
Play 2.8.14 is now available 👍 Please give it a try if now Java 17 works for you, but be aware that you have to upgrade some dependencies yourself, see the notes here: #11206 |
@mkurz thank you very much, I'll do a build & update here. |
@mkurz I just build my project & run unit + integrations tests with JDK 17. Everything works. Also, I was using guice 5.0.1 & I got some error. Apparetly they have a minor upgrade to support Java 17, https://github.com/google/guice/wiki/Guice510, you might want to update to that version for Play 2.9. Once I deploy a test branch, I'll also update here regarding any runtime issues I've faced. |
Great! (main is using Guice 5.1.0 already) |
Just tried upgrading, is below expected? It pops up during our tests. I don't see it mentioned in the notes. Should I create a ticket on sslconfig?
|
@francisdb it is mentioned. Apparently you're using self signed certificates. Try adding |
@gokhanoner mind pointing me to where it is mentioned? We are not doing anything special with certificates, just testing with OneServerPerSuiteWithComponents Created an issue to track this here: #11209 |
@francisdb under |
Found it -> #10883 (comment) @francisdb Also, pls keep in mind that this version, 2.8.14, doesn't officially support Java 17, its best effort. @mkurz can you also point out where this issue is mentioned, if any, other than this comment? |
Maybe we can adjust this info in command line:
|
@mkurz you might want to upgrade to latest 5.3 (5.3.18 as of now) in master, which contains a fix for Spring vulnerability. |
@gokhanoner scala-steward will do the upgrade for us 😉 |
Hi, |
Thanks. Waiting for the new release of play-ebean. |
@hedecai please check |
@PromanSEW We upgrade from 6.2.0-RC4 to 6.2.0-RC6 has this exception "javax.persistence.PersistenceException: models.xx is NOT an Entity Bean registered with this server? " in production environment (using sbt clean; sbt dist). Update: |
@hedecai also see playframework/play-ebean#290 |
We don't has the IllegalStateException, our app use Ebean 12.16.1 as play-ebean version. |
I'm facing the same problem but my project has more than 100 entities! 😢 |
@hedecai @ruyconolly Please try the latest, just released play-ebean version: https://github.com/playframework/play-ebean/releases/tag/6.2.0-RC7 |
Done in #11448, main branch in now Java 17 compatible out of the box (except the certifcate stuff from ssl-config, but that shouldn't really be a problem) |
👉 If you are looking for a way run Play 2.8.x with Java 17... Yes, that is possible since Play 2.8.15: https://github.com/playframework/playframework/releases/tag/2.8.15
Let's see how well Play plays with Java
1617.The goal here is to make Play work with upcoming Java 17 (release date: 2021/09/14) as early as possible, because just like Java 11, Java 17 will be a LTS version.
WIP: ---add-exports
scripted tests:
https://travis-ci.com/github/playframework/playframework/jobs/498243543#L5170-L5174
Microbenchmark and integration tests with akka's http2 endpoint fail
Failed Integration tests: https://travis-ci.com/github/playframework/playframework/jobs/498389129
See all the
java.net.SocketTimeoutException
s, http2 does not start. Also see the bottom of the logs, you will see theInaccessibleObjectException
s.Failed microbenchmarks: https://travis-ci.com/github/playframework/playframework/jobs/498367902#L1934-L1942
Error log
Will this be fixed when upgrading to akka-http 10.2.x?The problem is okhttp.--add-opens=java.base/sun.security.ssl=ALL-UNNAMED
Validate docs fail (but not relevant for now)
https://travis-ci.com/github/playframework/playframework/jobs/497685525#L4256
Error log
Line that causes the exception.
Problem: play-docs depends on unmaintained pegdown 1.6.0 (which is discussed here already), which depends on outdated parboiled-java 1.1.7, which depends on outdated ASM version 5.0.3 that has no support for newer JDKs. Even current parboiled 1.3.1 (which is the latest versions as time of this writing) only includes ASM 7.1, which still does not support Java 16. Only parboiled's master branch already depends on latest ASM 9.1.
However, this problem is not urgent and does not block Play from supporting Java 17, because this is "just" about "Validate docs (links, sample code, etc.)". We can and will continue running this jobs with Java 8, and even if ditch Java 8, we will probably only move the Java 11 as next step which will still work. So I think we are good for a couple more years (I mean in theory, we can even run this validation jobs with Java 8/11 forever).
We could also try to just override the ASM dependency, maybe that would be enough(?)