Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and deployment target #11

Merged
merged 4 commits into from Dec 17, 2020
Merged

Update dependencies and deployment target #11

merged 4 commits into from Dec 17, 2020

Conversation

jiayi-zhou
Copy link
Collaborator

@jiayi-zhou jiayi-zhou commented Dec 15, 2020 •
edited

Update to AccessibilitySnapshot 0.4.1 and Playbook 0.2.1 and update deployment target of example project to 14.2

ra1028
ra1028 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@ra1028 ra1028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jiayi-zhou

If you want to publish a new version to the cocoapods, add a new tag, and write a release on GitHub, and then the new version will be published automatically by github-actions.

@ra1028
Copy link
Member

ra1028 commented Dec 16, 2020

@jiayi-zhou
Ah sorry, looks CI was failed. I guess there are diffs after running format.
Please fix it, then if the CI is passed, you can merge this yorself.

@jiayi-zhou
Copy link
Collaborator Author

I ran this command locally and it seems to pass. I think this may be an issue with either our CI setup or a temporary issue with Github action itself (could be related to this: actions/runner-images#2247). I tried with a new PR: #12, and it fails here also. Should I merge this for now?

@ra1028
Copy link
Member

ra1028 commented Dec 17, 2020

@jiayi-zhou
Okay, then let's merge this for now. and revisit this after the maintenance :)

@ra1028 ra1028 merged commit 333d88b into main Dec 17, 2020
@ra1028 ra1028 deleted the update-deps branch December 17, 2020 03:41
@ra1028 ra1028 mentioned this pull request Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ra1028 ra1028 ra1028 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiayi-zhou @ra1028