Added response headers to set content types for api resources #152
+26
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is totally necessary. I wonder it we should make it as a middleware instead on each handler. |
|
Great question. I'm still spinning up on Go and the frameworks in place, so wasn't aware of that option. So, feel free to do it that way. I mostly just copy/pasted what I saw the |
|
Would it be possible to go ahead and get this merged in until we figure out another (potentially better) route? |
|
@mikesir87 I'll check it out today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a few API resources that didn't have the header set. Makes some JavaScript-related stuff easier when the headers are set.