Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ping more reliable. #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make ping more reliable. #137

wants to merge 1 commit into from

Conversation

marcosnils
Copy link
Contributor

Ping now creates a session and an instance once a minute.

@xetorthio ?

Ping now creates a session and an instance once a minute.
@xetorthio
Copy link
Contributor

This looks very promising. I think we should still check for available ram and hdd space before trying to create a session and instance.
The reasoning is that if you try to create a session or instance and it fails because of ram or hdd, probably is already too late, and we want to catch it before that. So we would put a good enough threshold, so we get notified and stop scheduling session in the instance.

@marcosnils
Copy link
Contributor Author

makes sense. I'll update and resend.

@marcosnils
Copy link
Contributor Author

I think we should still check for available ram and hdd space before trying to create a session and instance.

We can't really check HDD space in /ping as it's not exposed in /proc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants