Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Two HTML5 Backends Error #398

Merged
merged 1 commit into from Apr 15, 2021
Merged

Conversation

LuanEdCosta
Copy link
Contributor

@LuanEdCosta LuanEdCosta commented Apr 15, 2021

Description

Solution

  • I found THIS SOLUTION in the react-dnd repository.
  • To solve the problem a custom DndProvider was created. This component is located at src/components/CustomDndProvider.

IMPORTANT
Anywhere else on this site where you need a DndProvider, you must use CutomDndProvider to prevent the same error from happening again.

@github-actions
Copy link

Dicas para revisão de código

Commits

  • Título (1a linha do commit): apresentar resumo do que foi alterado/adicionado/removido.
    ex: adiciona action que salva parametros no backend; exibe rótulo no componente de selecao de dataset;
  • Descrição (outras linhas): dar mais detalhes de cada alteração:
    • motivos das alterações
      ex: havia um bug que causava...; nova funcionalidade que faz isso...; código foi movido para...;
    • bibliotecas adicionadas e versões (package.json)
      ex: atualiza para antd v4.6;
    • testes unitários criados/alterados
      ex: adiciona testes para a action fetchProjectSuccess;
  • Mensagens auto-explicativas! Quem revisa o código deve entender o que foi feito (e porque foi feito) sem perguntar para quem fez o commit.
  • Não devem ter conflitos. Solicitar que sejam resolvidas as ocorrências de "This branch has conflicts that must be resolved".

SonarCloud Quality Gate

  • Coverage > 80.0%, e sempre que possível = 100%
  • 0 Bugs, 0 Code Smells, 0 Vulnerabilities
  • São permitidos os seguintes Security Hotspots:
    • Make sure that using this pseudorandom number generator is safe here.
    • Make sure that using a regular expression is safe here.

Build Github actions COM SUCESSO

ReactJS

  • Usar Node 12 ou 14.
  • Remover console.log.
  • Não deixar código-fonte comentado.

Redux

As instruções a seguir foram retiradas do Redux Style Guide.

@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2021

Copy link
Member

@fberanizo fberanizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testei na .118 e pareceu corrigir o bug. :)
Não vou dar merge porque acho melhor o @schafferjrdev revisar também. :)

Copy link
Contributor

@schafferjrdev schafferjrdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@schafferjrdev schafferjrdev merged commit 4562ce9 into master Apr 15, 2021
@LuanEdCosta LuanEdCosta deleted the fix/two-html5-backends-error branch April 16, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants