This repository has been archived by the owner on Jun 10, 2019. It is now read-only.
introduce basic docker-support #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will mainly allow to use docker locally without having to set up npm and required dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will mainly allow to use docker locally without having to set up
npm and required dependencies
To properly support running the operator in Docker it would be great if the configuration could get passed in via environment variables. Additionally another means to pass in the passphrase would be needed, I could imagine to either also pass it in via environment variable or starting the operator in a locked mode and unlocking it via an API call.
This PR could resolve #14
It also requires the fix included in #35