Improve Dockerfile #25
base: master
Are you sure you want to change the base?
Conversation
This prevents breaks in the future if Debian releases a new stable version.
This is not necessary and just increases the size of the final image.
This only installs packages we really need and potentially saves a lot of MB.
No matching distribution found for opencv-python==4.3.0.36 (from felicette)
@milhouse1337 can review this better. Else I'll test and merge this over the weekend. |
@SuperSandro2000 Thank you for this, it looks great! 👍 You can even remove the comments, it was not intended to be pushed. 😅 @plant99 I will rebuild the image on Docker Hub, based on this update. |
@plant99 the Docker image has been updated. The size before: 572.88 MB (compressed) |
@milhouse1337 comments got removed. I was not sure what to do with them. I did some basic testing and one City generated a somewhat blurry image but the other was just black. This also happened with you old image so it is probably not the fault of my changes. |
@SuperSandro2000 could you please test it with I agree with the blurry and black image for some locations. Thanks for the review @milhouse1337 |
Amsterdam does also not work. |
Oh, weird. Let me look into it when I get back on a keyboard. |
bump |
1 similar comment
bump |
This saves just over 200MB uncompressed and follow some best practices.