Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

Improve Dockerfile #25

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

SuperSandro2000
Copy link

This saves just over 200MB uncompressed and follow some best practices.

docker images | grep felicette
felicette                                   latest              854f7da1165e        6 minutes ago       1.29GB
milhouse1337/felicette                      latest              be1fd7e006be        5 days ago          1.5GB

This prevents breaks in the future if Debian releases a new stable version.
This is not necessary and just increases the size of the final image.
This only installs packages we really need and potentially saves a lot of MB.
No matching distribution found for opencv-python==4.3.0.36 (from felicette)
@plant99
Copy link
Owner

plant99 commented Jul 31, 2020

@milhouse1337 can review this better. Else I'll test and merge this over the weekend.

@milhouse1337
Copy link

@SuperSandro2000 Thank you for this, it looks great! 👍

You can even remove the comments, it was not intended to be pushed. 😅

@plant99 I will rebuild the image on Docker Hub, based on this update.

@milhouse1337
Copy link

@plant99 the Docker image has been updated.
https://hub.docker.com/r/milhouse1337/felicette/tags

The size before: 572.88 MB (compressed)
After: 454.23 MB (compressed)

@SuperSandro2000
Copy link
Author

@milhouse1337 comments got removed. I was not sure what to do with them.

I did some basic testing and one City generated a somewhat blurry image but the other was just black. This also happened with you old image so it is probably not the fault of my changes.

@plant99
Copy link
Owner

plant99 commented Aug 1, 2020

@SuperSandro2000 could you please test it with -l Amsterdam ?

I agree with the blurry and black image for some locations.

Thanks for the review @milhouse1337

@SuperSandro2000
Copy link
Author

Amsterdam does also not work.

@plant99
Copy link
Owner

plant99 commented Aug 1, 2020

Oh, weird. Let me look into it when I get back on a keyboard.

@SuperSandro2000
Copy link
Author

bump

1 similar comment
@SuperSandro2000
Copy link
Author

bump

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants