Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scrolling in Firefox Mobile #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

newhinton
Copy link

Currently the width of planka extends the width of the device if too much content is available. This limits the width and hides the overflow like it does when the desktop window is resized

@meltyshev
Copy link
Member

Hi, thanks for the PR. But this change breaks the horizontal scroll when dragging a card.

@newhinton
Copy link
Author

hm, that is true. How is that scrolling implemented? Do you know a fix?

@meltyshev
Copy link
Member

Scrolling implemented inside the react-beautiful-dnd lib. I started to use a body with overflow-x when I was making columns to have its own scroll. If there other elements with overflow then drag scroll stops working and the lib just notifies that nested scroll containers aren't supported. I was looking for a fix, but I couldn't find it :(

@newhinton
Copy link
Author

Hm, thats sad. Should i close this pr for now and create a new ticket for it?

Also, on an unrelated topic, i found that creating some very basic files to satisfy requirements for a PWA, Planka works nearly flawless as one, and you have already a manifest.json. Is a PWA on your todo?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants