Skip to content

Commit

Permalink
fix: Decouple BASE_URL from Ingress host (#498)
Browse files Browse the repository at this point in the history
Closes #496
  • Loading branch information
rocketproto committed Aug 26, 2023
1 parent 5317950 commit 7d28abc
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/planka/Chart.yaml
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.1
version: 0.1.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
4 changes: 3 additions & 1 deletion charts/planka/templates/deployment.yaml
Expand Up @@ -64,7 +64,9 @@ spec:
name: planka-postgresql-svcbind-custom-user
key: uri
- name: BASE_URL
{{- if .Values.ingress.enabled }}
{{- if .Values.baseUrl }}
value: {{ .Values.baseUrl }}
{{- else if .Values.ingress.enabled }}
value: {{ printf "https://%s" (first .Values.ingress.hosts).host }}
{{- else }}
value: http://localhost:3000
Expand Down
5 changes: 5 additions & 0 deletions charts/planka/values.yaml
Expand Up @@ -17,6 +17,10 @@ fullnameOverride: ""
# Generate a secret using openssl rand -base64 45
secretkey: ""

# Base url for Planka. Will override `ingress.hosts[0].host`
# Defaults to `http://localhost:3000` if ingress is disabled.
baseUrl: ""

serviceAccount:
# Specifies whether a service account should be created
create: true
Expand Down Expand Up @@ -50,6 +54,7 @@ ingress:
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
hosts:
# Used to set planka BASE_URL if no `baseurl` is provided.
- host: planka.local
paths:
- path: /
Expand Down

0 comments on commit 7d28abc

Please sign in to comment.