WIP: enhancement/670-TweetPostAuthor #674
base: master
Are you sure you want to change the base?
Conversation
* Updated the preview item's Title so that it includes the twitter handle * Since IFTTT is connected directly, it takes the Title value and automatically posts it on Twitter * I added a check that only adds the twitter handle if it is populated and contains a value
I like it! Is there a chance to see how it will look in Twitter without pushing to prod? |
If you look at this tweet: https://twitter.com/PlanetXamarin/status/1284977181563781122 Instead of this:
In theory, if IFTTT is setup the way I think it is, it will start looking like this:
|
No it won't. This only changes how it looks on https://www.planetxamarin.com/preview and not the RSS feed itself. |
@Cheesebaron how would i be able to change what is sent to the RSS feed? |
You probably need to change the SyndicationItems here https://github.com/planetxamarin/planetxamarin/blob/master/src/Firehose.Web/Infrastructure/NewCombinedFeedSource.cs#L164 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What it they don't have a twitter account?
@jamesmontemagno If they don't have an author name or a twitter account, we'll just ignore it for now. |
We might be in business thanks to the Highest DotNet contributor on StackOverflow! I added this code after line 184 of NewCombinedFeedSource & I was able to update the RSS feed that is used by IFTTT:
I just need to update "SAAMER" to conditionally add the twitter handles instead if the names match our authors. |
Alright, maybe we should close this since the final approach was different from what I took in #721, and it's also quite messy |
THIS PR IS A WORK IN PROGRESS, DO NOT MERGE