restore type safety for queries #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusnorton
reviewed
May 3, 2024
linusnorton
reviewed
May 3, 2024
linusnorton
reviewed
May 3, 2024
linusnorton
reviewed
May 3, 2024
|
@miklcct thanks for the PR. I'm happy with it except for changing to async methods unnecessarily |
added 3 commits
May 3, 2024 11:56
Note it generates TS80006 suggesting that we use async / await
|
I have rebased this PR onto the latest master and added 2 more commits according to your suggestion to see if you are happy. |
This reverts commit 6c3c7c3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago the query method was made always returning
anyregardless of the type parameter. This pull request restores how it was intended to work.