Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/main/minor fixes #1412

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bugfix/main/minor fixes #1412

wants to merge 4 commits into from

Conversation

jonasraoni
Copy link
Contributor

No description provided.

@jonasraoni jonasraoni force-pushed the bugfix/main/minor-fixes branch 4 times, most recently from 69b4614 to 11e48d0 Compare June 4, 2023 07:27
asmecher
asmecher approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@asmecher asmecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need partial porting to stable-3_4_0? I'm looking e.g. at https://github.com/pkp/omp/pull/1412/files#diff-3a899a87f4935084a15647bb119256f752cc7623f451304ffcfeda1459b5fa70R161.

@jonasraoni
Copy link
Contributor Author

@asmecher Yes, some things should be fixed on the stable-3_4_0, I've created two new issues a couple of days ago:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmecher asmecher asmecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jonasraoni @asmecher