pkp/pkp-lib#9895 app key and encryption service integration #4257
Conversation
| ; cipher = 'aes-256-cbc' | ||
|
|
||
| ; Define should the cookie at user's end need to be encrypted | ||
| ; Enabling/Disbaling will force all user to re-login |
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| <install version="3.5.0.0"> | |||
| <code function="checkPhpVersion" /> | |||
| <code function="addAppKey" /> | |||
There was a problem hiding this comment.
This should be added as a migration, not a <code ...> addition in the Upgrade class.
There was a problem hiding this comment.
@asmecher I understand it should part of upgrade and need to moved to upgrade class but I am confused about the migration part . I does not modify/update any DB tables but update the config.inc.php to add a unique app key if the app_key variable defined/set in the config.inc.php file . thats why it's added as <code ...> to run. or I am misunderstanding something ?
There was a problem hiding this comment.
The <code ...> pattern leads to accumulating cruft in the Upgrade class, so we're using Migration classes instead for new code. Migrations are good for whatever, not just database schema adaptations!
for pkp/pkp-lib#9895