Bugfixes: locales and OMP series numbers #116
Open
+45
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@defstat, could you review this? Thanks! |
|
I fixed an other bug. If you tried to cite a chapter and there is no chapter author, then you will get an error. |
defstat
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs
CSL needs to choose the right language xml file a locale in format "xy-ZW". So it only uses a fallback "en-US" since we change the locales. In this solution I first look, if "xy-XY" exists and else I'm looking in an array with entries build "xy" => "xy-ZW". If tried to map all possible languages form https://github.com/citation-style-language/locales. Only for zh-CN and zh-TW I had no idea, how to decide which one is to use.
Series number in OMP was mapped to "volume", but should be mapped to "collection-number". See here: https://docs.citationstyles.org/en/stable/specification.html#appendix-iv-variables