Shellcode for fish

[mxcl]

Refs #704

[coveralls]

Pull Request Test Coverage Report for Build 6667484083

• 15 of 27 (55.56%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.7%) to 96.222%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/modes/shellcode.ts	15	27	55.56%

Totals
Change from base Build 6653611079:	-0.7%
Covered Lines:	1392
Relevant Lines:	1441

---

💛 - Coveralls

[Lythenas]

If you use a fish script instead of an sh script, you should be able to use something like this:

echo -n "exec " > "$d/x.$fish_pid"
for arg in $argv
    string escape $arg >> "$d/x.$fish_pid"
    echo -n " " >> "$d/x.$fish_pid"
end

And then in the definition of x call the script with fish "${tmp}/shellcode/x.$fish_pid". Or use a fish shebang. Not sure which is better.

I also tried to implement fish support here: https://github.com/Lythenas/pkgx/tree/fish-support I basically just translated the posix code, and since then I think there were changes of the shellcode in pkgx. But feel free to use that as a reference if it is useful. I didn't open a PR because I wasn't confident that my code is correct and I also didn't really like the implementation (the --fish flag and the way I built the shellcode).

[mxcl]

thank you this is very useful!

[FlatMapIO]

@mxcl Don't forget this :)

[yoroshikun]

Very eager for this~

[joshmedeski]

@mxcl let us know if you need any testers for this! Looking forward to seeing this merged.

[mxcl]

I think I need to refactor the shellcode and other related pieces before this will be maintainable. I don't use fish (only because in general I stick with defaults so that I know what most of my users deal with on a day to day basis) and as a result it would be easy for it to end up breaking unless the underlying infra is solid.

Also not knowing fish it's hard to write. I am mostly using ChatGPT to translate.

[netzhuffle]

@mxcl Do you have anything in specific about how I might be able to help?

[joshmedeski]

@mxcl I've got fish scripting experience too, let us know if you want support.

[amok]

I'm at your service too, @mxcl. Looking forward to fish support