Force texImage2D upload for videos #6088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4089
This defaults
texImage2D
uploading instead oftexSubImage2D
for VideoResource objects.See for more information and performance measurements: http://codeflow.org/issues/slow_video_to_texture/
Build:
http://pixijs.download/fix-video-performance/pixi.min.js
Example:
https://pixiplayground.com/#/edit/jpeAPzXpQFY336WzsTKqn (PR)
https://pixiplayground.com/#/edit/9vDVREwmsMLTMNoCgW2VI (5.1.3)
Measurements (Chrome 76)
I did a small benchmark in Chrome to see the performance. At least in Chrome,
texImage2D
is faster (although on my laptop I didn't perceive much of a different, would probably show up more on mobile/slower devices).texSubImage2D
texImage2D