Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'angle' property for DisplayObject #5129

Merged
merged 4 commits into from
Oct 1, 2018

Conversation

themoonrat
Copy link
Member

The proposed solution from #4579 which got recently closed.

I've had angle as a property like this on my version of PIXI for a while, and it makes it so much easier to configure a display object's rotation via JSON :)

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@bigtimebuddy
Copy link
Member

Might be nice to add a simple unit test or two. To validate the API

…of the same transformation. Changing one effects the other
@themoonrat
Copy link
Member Author

@bigtimebuddy done!

@bigtimebuddy bigtimebuddy added this to the v5.0.0-alpha.4 milestone Sep 24, 2018
@bigtimebuddy bigtimebuddy merged commit 86e0fe0 into next Oct 1, 2018
@bigtimebuddy bigtimebuddy deleted the feature/next-angle-property branch October 1, 2018 04:08
@lock
Copy link

lock bot commented Oct 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants