backport filter pool key

[ivanpopelyshev]

#3866 and other issues.

@Patrick-Hammond confirmed that we still have the problem, and I want to solve it radical way.

[ivanpopelyshev]

Works like before:

https://jsfiddle.net/3kvazjw1/17/ - key = 'screen'
https://jsfiddle.net/3kvazjw1/20/ - key = '33554944'

I dont have examples with a bug, but I'm sure that solution is correct - we store the result instead of recalculation.

[bigtimebuddy]

“I’m sure the solution is correct”, I don’t like any uncertainty here. Can you please try to dig up an erroring example so we can verify?

[ivanpopelyshev]

Its the same problem as in #4745 and in #4579 (comment)

Extra multiplication and division can change the number, element cant return to the pool because key was changed.

Are you sure you want a third demo for it?

[ivanpopelyshev]

You are right. it was fun to reproduce it, we have one more case. Here it is: https://jsfiddle.net/3kvazjw1/21/

Chrome at 90% zoom gives us 0.8999999761581421

var res = 0.8999999761581421;
console.log(1 / res * res);

shows 0.9999999999999999

That's why minWidth and minHeight are less than expected, and the key is wrong.

[bigtimebuddy]

I'm satisfied here, this seems like a good solution. Thanks for verifying @ivanpopelyshev

[cursedcoder]

+1, math is ridiculous in js, for example const a = 0.1 + 0.7 will give 0.799999999999999

[ivanpopelyshev]

@cursedcoder all according to IEEE 754

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.