Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: buffer upload for texture #10537

Merged
merged 5 commits into from
May 17, 2024
Merged

fix: buffer upload for texture #10537

merged 5 commits into from
May 17, 2024

Conversation

GoodBoyDigital
Copy link
Member

@GoodBoyDigital GoodBoyDigital commented May 15, 2024 •
edited

Description of change

The upload code for WebGL was a behaving a bit funny when rep-uploading a buffer. This little refactor fixes it and simplifies the code a bit by doing the same kind of upload for webGL1 and 2 (both APIs supported)

I also renamed the BufferSource.ts file to BufferImageSource to match the internal class name

@korbit-ai Korbit AI
Copy link

korbit-ai bot commented May 15, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

korbit-ai[bot]
korbit-ai bot reviewed May 15, 2024
View reviewed changes
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code and did not find any issues!

Please note that I can make mistakes, and you should still encourage your team to review your code as well.

@GoodBoyDigital
Copy link
Member Author

oops! broke some webGL1 tests.. please hold!

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 15, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@GoodBoyDigital
fix up
bcdaa9f 
rename file to BufferImageSource
@GoodBoyDigital
fix tests
78b3bea
ivanpopelyshev
ivanpopelyshev approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@ivanpopelyshev ivanpopelyshev left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's real fix

I just did the same in my fork

github-actions[bot]
github-actions bot reviewed May 17, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in this format:

chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution

@Zyie Zyie changed the title Bugfix: fix up buffer upload for texture fix: buffer upload for texture May 17, 2024
@Zyie Zyie added ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8 labels May 17, 2024
@Zyie Zyie added this pull request to the merge queue May 17, 2024
Merged via the queue into dev with commit 3acd10b May 17, 2024
5 of 6 checks passed
@Zyie Zyie deleted the bugfix/buffer-upload branch May 17, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@korbit-ai korbit-ai[bot] korbit-ai left review comments

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Awaiting requested review from Zyie

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GoodBoyDigital @ivanpopelyshev @bigtimebuddy @Zyie