Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mask issue when setting to null and back #10536

Merged
merged 2 commits into from
May 15, 2024
Merged

fix mask issue when setting to null and back #10536

merged 2 commits into from
May 15, 2024

Conversation

GoodBoyDigital
Copy link
Member

Description of change

Fixes a little regression bug when doing the following:

 thing.mask = mask;
 thing.mask = null;
 thing.mask = mask; // would throw as mask effect refference was not removed.
Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

Copy link

korbit-ai bot commented May 15, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

Copy link

codesandbox-ci bot commented May 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 318a482:

Sandbox Source
pixi.js-sandbox Configuration

tests/scene/mask.test.ts Outdated Show resolved Hide resolved
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code and did not find any issues!


Please note that I can make mistakes, and you should still encourage your team to review your code as well.

@Zyie Zyie added ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8 labels May 15, 2024
@Zyie Zyie added this pull request to the merge queue May 15, 2024
Merged via the queue into dev with commit f68c348 May 15, 2024
4 checks passed
@Zyie Zyie deleted the bugfix/mask-double-set branch May 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants